[SPARK-50246][SQL] Assign appropriate error condition for _LEGACY_ERROR_TEMP_2167: INVALID_JSON_RECORD_TYPE
#48775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OR_TEMP_2167: MALFORMED_RECORD_IN_SCHEMA_INFERENCE
MaxGekk
requested changes
Nov 7, 2024
| }, | ||
| "sqlState" : "22023" | ||
| }, | ||
| "MALFORMED_RECORD_IN_SCHEMA_INFERENCE" : { |
Member
There was a problem hiding this comment.
The error condition is pretty much related to JSON. Let's reflect this in its name.
Also the record might be a correct JSON record but has unexpected type.
Contributor
Author
There was a problem hiding this comment.
Sounds good.
Just applied the comments, thanks!
MaxGekk
approved these changes
Nov 13, 2024
MaxGekk
changed the title
_LEGACY_ERROR_TEMP_2167: MALFORMED_RECORD_IN_SCHEMA_INFERENCE_LEGACY_ERROR_TEMP_2167: INVALID_JSON_RECORD_TYPE
Member
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to Integrate
_LEGACY_ERROR_TEMP_2167intoINVALID_JSON_RECORD_TYPEWhy are the changes needed?
To improve the error message by assigning proper error condition and SQLSTATE
Does this PR introduce any user-facing change?
No, only user-facing error message improved
How was this patch tested?
Updated the existing tests
Was this patch authored or co-authored using generative AI tooling?
No