Skip to content

[SPARK-50248][SQL] Assign appropriate error condition for _LEGACY_ERROR_TEMP_2058: INVALID_PARTITION_VALUE #48778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itholic wants to merge 3 commits into from
Closed

[SPARK-50248][SQL] Assign appropriate error condition for _LEGACY_ERROR_TEMP_2058: INVALID_PARTITION_VALUE #48778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01cebb5
[SPARK-50248][SQL] Assign appropriate error condition for _LEGACY_ERR…
itholic Nov 6, 2024
1589c6a
pull master
itholic Nov 6, 2024
7920c7e
adjusted comment
itholic Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2960,6 +2960,12 @@
},
"sqlState" : "42601"
},
"INVALID_PARTITION_VALUE" : {
"message" : [
"Failed to cast value <value> to data type <dataType> for partition column <columnName>. Ensure the value matches the expected data type for this partition column."
],
"sqlState" : "42846"
},
"INVALID_PROPERTY_KEY" : {
"message" : [
"<key> is an invalid property key, please use quotes, e.g. SET <key>=<value>."
Expand Down Expand Up @@ -6954,11 +6960,6 @@
"Unable to clear partition directory <path> prior to writing to it."
]
},
"_LEGACY_ERROR_TEMP_2058" : {
"message" : [
"Failed to cast value `<value>` to `<dataType>` for partition column `<columnName>`."
]
},
"_LEGACY_ERROR_TEMP_2059" : {
"message" : [
"End of stream."
Expand Down
8 changes: 4 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,11 +795,11 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
def failedToCastValueToDataTypeForPartitionColumnError(
value: String, dataType: DataType, columnName: String): SparkRuntimeException = {
new SparkRuntimeException(
errorClass = "_LEGACY_ERROR_TEMP_2058",
errorClass = "INVALID_PARTITION_VALUE",
messageParameters = Map(
"value" -> value,
"dataType" -> dataType.toString(),
"columnName" -> columnName))
"value" -> toSQLValue(value),
"dataType" -> toSQLType(dataType),
"columnName" -> toSQLId(columnName)))
}

def endOfStreamError(): Throwable = {
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ class FileIndexSuite extends SharedSparkSession {
exception = intercept[SparkRuntimeException] {
fileIndex.partitionSpec()
},
condition = "_LEGACY_ERROR_TEMP_2058",
parameters = Map("value" -> "foo", "dataType" -> "IntegerType", "columnName" -> "a")
condition = "INVALID_PARTITION_VALUE",
parameters = Map("value" -> "'foo'", "dataType" -> "\"INT\"", "columnName" -> "`a`")
)
}

Expand Down