Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Nov 6, 2024

What changes were proposed in this pull request?

This PR proposes to Integrate _LEGACY_ERROR_TEMP_2075 into UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE

Why are the changes needed?

To improve the error message by assigning proper error condition and SQLSTATE

Does this PR introduce any user-facing change?

No, only user-facing error message improved

How was this patch tested?

Updated the existing tests

Was this patch authored or co-authored using generative AI tooling?

No

…OR_TEMP_2075: UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE
@itholic itholic requested a review from MaxGekk November 6, 2024 20:14
@github-actions github-actions bot added the SQL label Nov 6, 2024
Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
@MaxGekk
Copy link
Member

MaxGekk commented Nov 13, 2024

+1, LGTM. Merging to master.
Thank you, @itholic.

@MaxGekk MaxGekk closed this in 40ffdef Nov 13, 2024
@itholic
Copy link
Contributor Author

itholic commented Nov 14, 2024

Thanks @MaxGekk for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants