[SPARK-50139][INFRA][SS][PYTHON] Introduce scripts to re-generate and checking StateMessage_pb2.py and StateMessage_pb2.pyi #48815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dongjoon-hyun
approved these changes
Nov 12, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
| # source: StateMessage.proto | ||
| # Protobuf Python Version: 5.27.3 | ||
| # source: org/apache/spark/sql/execution/streaming/StateMessage.proto | ||
| # Protobuf Python Version: 5.28.3 |
Contributor
Contributor
There was a problem hiding this comment.
The changes LGTM, thanks!
Member
|
Thank you, @LuciferYang , @zhengruifeng , @bogao007 . Merged to master for Apache Spark 4.0.0 on February 2024. |
Contributor
Author
|
Thanks @dongjoon-hyun @zhengruifeng and @bogao007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr includes the following changes:
dev/connect-gen-protos.shscript to support the generation of.pyfiles from.protofiles for both theconnectandstreamingmodules simultaneously. Rename the script todev/gen-protos.sh. Additionally, to maintain compatibility with previous development practices, this pull request (PR) introducesdev/connect-gen-protos.shanddev/streaming-gen-protos.shas wrappers arounddev/gen-protos.sh.After this PR, you can use:
or
to regenerate the corresponding
.pyfiles for the respective modules.dev/connect-check-protos.pyscript to check the generated results for both theconnectandstreamingmodules simultaneously, and rename it todev/check-protos.py. Additionally, update the invocation of the check script inbuild_and_test.yml.Why are the changes needed?
Provid tools for re-generate and checking
StateMessage_pb2.pyandStateMessage_pb2.pyi.Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No