[SPARK-49611][SQL][FOLLOW-UP] Make collations TVF consistent and return null on no result for country and language #48835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatomic
approved these changes
Nov 13, 2024
MaxGekk
approved these changes
Nov 13, 2024
Member
|
+1, LGTM. Merging to master. |
MaxGekk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It was noticed that we return null for country and language for collations TVF when collation is UTF8_*, but when information is missing in ICU we return empty string.
Why are the changes needed?
Making behaviour consistent.
Does this PR introduce any user-facing change?
No, this is all in Spark 4.0, so addition of this TVF was not released yet.
How was this patch tested?
Existing test.
Was this patch authored or co-authored using generative AI tooling?
No.