[SPARK-50304][INFRA] Remove (any|empty).proto from RAT exclusion
#48837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this PR, @viirya ? |
Member
Author
viirya
approved these changes
Nov 13, 2024
Member
Author
|
Thank you, @viirya ! |
HyukjinKwon
approved these changes
Nov 14, 2024
Member
|
Merged to master. |
Member
Author
|
Thank you, @HyukjinKwon . |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 14, 2024
### What changes were proposed in this pull request? This PR aims to remove `(any|empty).proto` from RAT exclusion. ### Why are the changes needed? `(any|empty).proto` files were never a part of Apache Spark repository. Those files were only used in the initial `Connect` PR and removed before merging. - #37710 - Added: 45c7bc5 - Excluded from RAT check: cf6b19a - Removed: 4971980 ### Does this PR introduce _any_ user-facing change? No. This is a dev-only change. ### How was this patch tested? Pass the CIs or manual check. ``` $ ./dev/check-license Ignored 0 lines in your exclusion files as comments or empty lines. RAT checks passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48837 from dongjoon-hyun/SPARK-50304. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 33378a6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
I backported this to branch-3.5 too~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
(any|empty).protofrom RAT exclusion.Why are the changes needed?
(any|empty).protofiles were never a part of Apache Spark repository. Those files were only used in the initialConnectPR and removed before merging.Does this PR introduce any user-facing change?
No. This is a dev-only change.
How was this patch tested?
Pass the CIs or manual check.
Was this patch authored or co-authored using generative AI tooling?
No.