[SPARK-50312][SQL] SparkThriftServer createServer parameter passing error when kerberos is true #48855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror when kerberos is true
CuiYanxiang
changed the title
Contributor
Author
|
cc @cloud-fan |
yaooqinn
approved these changes
Nov 15, 2024
Member
|
Nice catch. (I'm a bit surprised that such a long-term bug was present.) |
yaooqinn
pushed a commit
that referenced
this pull request
Nov 15, 2024
…rror when kerberos is true
### What changes were proposed in this pull request?
When kerberos is enabled and SparkThriftServer is started, the service delivery parameters keytab and principal are created when hadoop authentication errors occur
`saslServer = ShimLoader.getHadoopThriftAuthBridge().createServer(principal, keytab);`
`public Server createServer(String keytabFile, String principalConf) throws TTransportException {
return new Server(keytabFile, principalConf);
}`
### Why are the changes needed?
Failed to start SparkThriftServer when kerberos is true
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
verified
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #48855 from CuiYanxiang/SPARK-50312.
Authored-by: cuiyanxiang <kaer@startdt.com>
Signed-off-by: Kent Yao <yao@apache.org>
(cherry picked from commit 3237885)
Signed-off-by: Kent Yao <yao@apache.org>
Member
|
Merged to master and 3.5. Thank you @CuiYanxiang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When kerberos is enabled and SparkThriftServer is started, the service delivery parameters keytab and principal are created when hadoop authentication errors occur
saslServer = ShimLoader.getHadoopThriftAuthBridge().createServer(principal, keytab);public Server createServer(String keytabFile, String principalConf) throws TTransportException { return new Server(keytabFile, principalConf); }Why are the changes needed?
Failed to start SparkThriftServer when kerberos is true
Does this PR introduce any user-facing change?
No
How was this patch tested?
verified
Was this patch authored or co-authored using generative AI tooling?
No