Skip to content

Conversation

@vladimirg-db
Copy link
Contributor

What changes were proposed in this pull request?

Factor out alias resolution code to the AliasResolution object.

Why are the changes needed?

Some Analyzer code will be used in both fixed-point and single-pass Analyzers. Also, Analyzer.scala is 4K+ lines long, so it makes sense to gradually split it.

Context: https://issues.apache.org/jira/browse/SPARK-49834

Does this PR introduce any user-facing change?

No. It's a pure refactoring.

How was this patch tested?

Existing tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Nov 15, 2024
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI.

@MaxGekk
Copy link
Member

MaxGekk commented Nov 15, 2024

+1, LGTM. Merging to master.
Thank you, @vladimirg-db.

@MaxGekk MaxGekk closed this in cc81ed0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants