[SPARK-50327][SQL] Factor out function resolution to be reused in the single-pass Analyzer #48858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
commented
Nov 15, 2024
| extends DataTypeErrorsBase with LookupCatalog { | ||
| private val v1SessionCatalog = catalogManager.v1SessionCatalog | ||
|
|
||
| private val trimWarningEnabled = new AtomicBoolean(true) |
Contributor
Author
There was a problem hiding this comment.
Since this atomic boolean was in object FunctionResolution inside class Analyzer, we have to move it to class FunctionResolution, and not to global object FunctionResolution. @MaxGekk please correct me if I'm wrong.
MaxGekk
approved these changes
Nov 15, 2024
| extends DataTypeErrorsBase with LookupCatalog { | ||
| private val v1SessionCatalog = catalogManager.v1SessionCatalog | ||
|
|
||
| private val trimWarningEnabled = new AtomicBoolean(true) |
Member
|
+1, LGTM. Merging to master. |
|
Hi, @vladimirg-db Do you have the JIRAs related to the Single-pass Analyzer work aggregated into a certain epic? This would facilitate tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Factor out function resolution code to the
FunctionResolutionobject.Why are the changes needed?
Some Analyzer code will be used in both fixed-point and single-pass Analyzers. Also, Analyzer.scala is 4K+ lines long, so it makes sense to gradually split it.
Context: https://issues.apache.org/jira/browse/SPARK-49834
Does this PR introduce any user-facing change?
No. It's a pure refactoring.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.