[SPARK-50334][SQL] Extract common logic for reading the descriptor of PB file

[panbingkun]

What changes were proposed in this pull request?

The pr aims to

• extract common logic for reading the descriptor of PB file to one place.
• at the same time, when using the from_protobuf or to_protobuf function in connect-client and spark-sql (or spark-shell), the spark error-condition thrown when the PB file is not found or read fails will be aligned.

Why are the changes needed?

I found that the logic for reading the descriptor of PB file is scattered in various places in the spark code repository, eg:

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/toFromProtobufSqlFunctions.scala

Lines 37 to 48 in a01856d

	def readDescriptorFileContent(filePath: String): Array[Byte] = {
	try {
	FileUtils.readFileToByteArray(new File(filePath))
	} catch {
	case ex: FileNotFoundException =>
	throw new RuntimeException(s"Cannot find descriptor file at path: $filePath", ex)
	case ex: NoSuchFileException =>
	throw new RuntimeException(s"Cannot find descriptor file at path: $filePath", ex)
	case NonFatal(ex) =>
	throw new RuntimeException(s"Failed to read the descriptor file: $filePath", ex)
	}
	}

spark/sql/api/src/main/scala/org/apache/spark/sql/protobuf/functions.scala

Lines 304 to 315 in a01856d

	private def readDescriptorFileContent(filePath: String): Array[Byte] = {
	try {
	Files.readAllBytes(Paths.get(filePath))
	} catch {
	case ex: FileNotFoundException =>
	throw CompilationErrors.cannotFindDescriptorFileError(filePath, ex)
	case ex: NoSuchFileException =>
	throw CompilationErrors.cannotFindDescriptorFileError(filePath, ex)
	case NonFatal(ex) =>
	throw CompilationErrors.descriptorParseError(ex)
	}
	}

spark/connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala

Lines 231 to 241 in a01856d

	def readDescriptorFileContent(filePath: String): Array[Byte] = {
	try {
	FileUtils.readFileToByteArray(new File(filePath))
	} catch {
	case ex: FileNotFoundException =>
	throw QueryCompilationErrors.cannotFindDescriptorFileError(filePath, ex)
	case ex: NoSuchFileException =>
	throw QueryCompilationErrors.cannotFindDescriptorFileError(filePath, ex)
	case NonFatal(ex) => throw QueryCompilationErrors.descriptorParseError(ex)
	}
	}

• I think we should gather it together to reduce the cost of maintenance.
• Align spark error-condition to improve consistency in end-user experience.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

[MaxGekk]

ah, you migrated the errors on error conditions too. Could you reflect this in PR's description and in the title.

[panbingkun]

Yeap, very detailed disclosure, has been updated!
thanks!

[MaxGekk]

+1, LGTM. Merging to master.
Thank you, @panbingkun.