Char varchar #48883
Draft
Char varchar #48883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailom-db
reviewed
Nov 19, 2024
sql/api/src/main/scala/org/apache/spark/sql/types/CharType.scala
Outdated
Show resolved
Hide resolved
| case (CharType(l1), CharType(l2)) => l1 == l2 | ||
| case (VarcharType(l1), VarcharType(l2)) => l1 == l2 | ||
| case (CharType(_) | VarcharType(_), _: StringType) => false | ||
| case (_: StringType, CharType(_) | VarcharType(_)) => false | ||
| case (_: StringType, _: StringType) => true |
There was a problem hiding this comment.
@stefankandic does this seem ok to you? I do not want to break delta. Is this only used in ddl operations?
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/VarcharType.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
Show resolved
Hide resolved
# Conflicts: # sql/core/src/test/resources/sql-tests/results/group-by-all-mosha.sql.out
cloud-fan
reviewed
Nov 19, 2024
| @@ -30,7 +30,9 @@ import org.apache.spark.sql.catalyst.util.CollationFactory | |||
| * The id of collation for this StringType. | |||
| */ | |||
| @Stable | |||
| class StringType private (val collationId: Int) extends AtomicType with Serializable { | |||
| class StringType private[spark] (val collationId: Int, val maxLength: Option[Int] = None) | |||
There was a problem hiding this comment.
why do we need to have the length info in the base StringType?
cloud-fan
reviewed
Nov 19, 2024
| obj.isInstanceOf[StringType] && obj.asInstanceOf[StringType].collationId == collationId | ||
| override def equals(obj: Any): Boolean = { | ||
| obj match { | ||
| case s: StringType => s.collationId == collationId && s.maxLength == maxLength |
There was a problem hiding this comment.
We should exclude char/varchar here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change type hierarchy so that CharType and VarcharType extend StringType.
Why are the changes needed?
This change is a step towards to properly supporting char and varchar types.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests in
DataTypeSuite.Was this patch authored or co-authored using generative AI tooling?
No.