[SPARK-50366][SQL] Isolate user-defined tags on thread level for SparkSession in Classic #48906
+120
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xupefei
changed the title
HyukjinKwon
reviewed
Nov 20, 2024
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
reviewed
Nov 20, 2024
| * A UUID that is unique on the thread level. Used by managedJobTags to make sure that a same | ||
| * tag from two threads does not overlap in the underlying SparkContext/SQLExecution. | ||
| */ | ||
| private[sql] lazy val threadUuid = new InheritableThreadLocal[String] { |
There was a problem hiding this comment.
Could we have a simple test for this inheritance? Otherwise, looks fine from a cursory look.
There was a problem hiding this comment.
|
cc @itholic too |
itholic
approved these changes
Nov 21, 2024
itholic
reviewed
Nov 21, 2024
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Nov 22, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR changes the implementation of user-provided tags to be thread-local, so that tags added by two threads to the same SparkSession do not interfere with each other.
Overlaps (from the
SparkContextperspective) are avoided by introducing a thread-local random UUID which is attached to all tags in the same thread.Why are the changes needed?
To make tags isolated per thread.
Does this PR introduce any user-facing change?
Yes, user-provided tags are now isolated on the session level.
How was this patch tested?
Local test.
Was this patch authored or co-authored using generative AI tooling?
No.