[SPARK-50373] Prohibit Variant from set operations #48909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gene-db @cloud-fan Can you please look at this? Thanks! |
gene-db
approved these changes
Nov 20, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
Show resolved
Hide resolved
dtenedor
approved these changes
Nov 21, 2024
|
@dtenedor This PR prohibits |
…ariant_distinct_fix
…hub.com/harshmotw-db/spark into variant_distinct_fix
cloud-fan
approved these changes
Dec 2, 2024
|
thanks, merging to master! |
asfgit
pushed a commit
that referenced
this pull request
Dec 9, 2024
### What changes were proposed in this pull request? Prior to this PR, repartition by Variant producing expressions wasn't blocked during analysis. It should be blocked because Variant equality is not defined. It is similar to [this PR](#48909) which blocked Variant from Set operations. ### Why are the changes needed? Variant equality is not defined yet and therefore shouldn't be allowed in repartitioning. ### Does this PR introduce _any_ user-facing change? Yes, prior to this PR, Variants repartition did not throw a well defined error. ### How was this patch tested? Unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49080 from harshmotw-db/harsh-motwani_data/variant_repartition. Authored-by: Harsh Motwani <harsh.motwani@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prior to this PR, Variant columns could be used with set operations like
DISTINCT,INTERSECTandEXCEPT. This PR prohibits this behavior since Variant is not orderable.Why are the changes needed?
Variant equality is not defined, and therefore, these operations are also undefined.
Does this PR introduce any user-facing change?
Yes, users will now no longer be able to perform set operations on variant columns.
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No