[SPARK-50383][CORE] Support Virtual Threads in REST Submission API
#48923
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Virtual Threads in REST Submission API
viirya
approved these changes
Nov 21, 2024
|
Thank you, @viirya ! |
viirya
reviewed
Nov 21, 2024
| val newVirtualThreadPerTaskExecutor = | ||
| classOf[Executors].getMethod("newVirtualThreadPerTaskExecutor") | ||
| val service = newVirtualThreadPerTaskExecutor.invoke(null).asInstanceOf[ExecutorService] | ||
| threadPool.setVirtualThreadsExecutor(service) |
There was a problem hiding this comment.
The thread number configured for the threadPool also determines the number of virtual threads?
There was a problem hiding this comment.
Yes, AFAIK, this is orthogonally handled in Jetty layer, @viirya .
|
BTW, after merging #48921, I need to rebase this PR to resolve the conflicts. |
dongjoon-hyun
force-pushed
the
SPARK-50383
branch
from
cf104cb
to
d7f6dc7
Compare
|
Rebased to master to resolve conflicts~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support JEP-444: Virtual Threads in REST Submission API for Apache Spark 4.0.0.
Why are the changes needed?
Virtual Threadsbecomes an official feature in Java 21.In addition,
Jetty 11supportsVirtual Threads.We had better provide a way to use it via a new option
spark.master.rest.virtualThread.enabled, which is enabled in Java 21 runtime. Please note that this aims for high-throughput concurrency.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.