[SPARK-50776][K8S][TESTS][FOLLOWUP] Fix code style #49444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
closing in favor of #49443. |
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jan 10, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Thank you. I manually tested this, @panbingkun .
Let's merge this because mine is blocked by other parts.
$ dev/lint-scala
Using SPARK_LOCAL_IP=localhost
Scalastyle checks passed.
Scalafmt checks passed.
Member
|
Merged to master. |
Contributor
|
@panbingkun , thank you for the follow-up style fix. I'll watch for this in the future. @dongjoon-hyun , thank you for looking at fixing the linter script. |
Contributor
Author
Okay, thanks :) ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to fix code style, following up https://github.com/apache/spark/pull/49428/files
Why are the changes needed?
Fix minor issue as follows:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually check & pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.