Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Mar 9, 2015

.../common.

No code changes. Left the shuffle-related files in the shuffle module.

…ork/common.

No code changes. Left the shuffle-related files in the shuffle module.
@SparkQA
Copy link

SparkQA commented Mar 9, 2015

Test build #28399 has started for PR 4953 at commit 664ef30.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 9, 2015

Test build #28399 has finished for PR 4953 at commit 664ef30.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28399/
Test PASSed.

@srowen
Copy link
Member

srowen commented Mar 9, 2015

It's strictly a code move, from child to parent module. Although I've never been that familiar with this code, I understand the motivation, to use it from the other child module, which seems sound. I'll let it stay open for a day or two in case there are other thoughts. If not I think this can merge.

@aarondav
Copy link
Contributor

aarondav commented Mar 9, 2015

LGTM too.

@asfgit asfgit closed this in 5b335bd Mar 11, 2015
@vanzin vanzin deleted the SPARK-6228 branch March 11, 2015 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants