[SPARK-50511][PYTHON][FOLLOWUP] Avoid wrapping streaming Python data source error messages #49532
+33
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HyukjinKwon |
dongjoon-hyun
approved these changes
Jan 16, 2025
dongjoon-hyun
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Oh, the removal of PySparkRuntimeError causes two Python linter error. Could you fix them, @allisonwang-db ?
./python/pyspark/sql/streaming/python_streaming_source_runner.py:24:1: F401 'pyspark.errors.PySparkRuntimeError' imported but unused
from pyspark.errors import IllegalArgumentException, PySparkAssertionError, PySparkRuntimeError
^
./python/pyspark/sql/worker/python_streaming_sink_runner.py:23:1: F401 'pyspark.errors.PySparkRuntimeError' imported but unused
from pyspark.errors import PySparkAssertionError, PySparkRuntimeError
^
2 F401 'pyspark.errors.PySparkRuntimeError' imported but unused
dongjoon-hyun
previously approved these changes
Jan 17, 2025
HyukjinKwon
approved these changes
Jan 17, 2025
dongjoon-hyun
previously requested changes
Jan 22, 2025
There was a problem hiding this comment.
To @allisonwang-db , please rebase this PR once more and fix the unit test.
[info] *** 4 TESTS FAILED ***
[error] Failed: Total 12090, Failed 4, Errors 0, Passed 12086, Ignored 33, Canceled 1
[error] Failed tests:
[error] org.apache.spark.sql.execution.python.PythonStreamingDataSourceSimpleSuite
[error] org.apache.spark.sql.execution.python.PythonStreamingDataSourceSuite
[error] (sql / Test / test) sbt.TestsFailedException: Tests unsuccessful
allisonwang-db
force-pushed
the
spark-50511-streaming-pyds-err
branch
from
f6a66c1 to
2d0a638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow up for #49092. It removes the extra try catch during streaming Python data source execution.
Why are the changes needed?
To make the error message more user-friendly and avoid nested error messages:
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no