[SPARK-51045][TESTS] Regenerate benchmark results after upgrading to Scala 2.13.16 #49744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
Member
Author
|
Currently, two benchmark failures are detected and I'm looking at them. |
Member
Author
|
This PR is ready. |
Member
Author
|
Could you review this PR when you have some time, @huaxingao ? |
Member
Author
|
All tests passed.
|
Member
Author
|
Thank you, @huaxingao ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 13, 2025
### What changes were proposed in this pull request?
This PR aims to regenerate benchmark results.
### Why are the changes needed?
We have 3 goals.
1. Make the results up-to-date with the code because the previous results were generated 7 months ago on 2025-01-30.
- #49744
3. Add the missed Java 24 test result, `RecursiveCTEBenchmark-jdk21-results.txt`
4. Fix the misgenerated result via GitHub Action generated result.
https://github.com/apache/spark/blob/ebf4dd1889f3404e856723f66851af48751b469f/sql/core/benchmarks/RecursiveCTEBenchmark-results.txt#L6
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #52005 from dongjoon-hyun/SPARK-53266.
Lead-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Co-authored-by: dongjoon-hyun <dongjoon-hyun@users.noreply.github.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to regenerate benchmark results of
masterafter upgrading to Scala 2.13.16.Why are the changes needed?
To check a regression again. Currently, there is only one known benchmark suite failure.
from_json#49411 (comment)Does this PR introduce any user-facing change?
No, this updates only test results.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.