Skip to content

[SPARK-6296] [SQL] Added equals to Column #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vlyubin wants to merge 1 commit into from
Closed

[SPARK-6296] [SQL] Added equals to Column #4988

vlyubin wants to merge 1 commit into from

Conversation

@vlyubin
Copy link
Contributor

@vlyubin vlyubin commented Mar 12, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28488 has started for PR 4988 at commit fb3385f.

  • This patch merges cleanly.

@sryza
Copy link
Contributor

sryza commented Mar 12, 2015

Mind including [SQL] in the title so that this gets sorted properly?

@vlyubin vlyubin changed the title [SPARK-6296] Added equals to Column [SPARK-6296] [SQL] Added equals to Column Mar 12, 2015
@rxin
Copy link
Contributor

rxin commented Mar 12, 2015

I think once you do that, you'd need to define hashCode as well?

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28488 has finished for PR 4988 at commit fb3385f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28488/
Test PASSed.

@vlyubin vlyubin force-pushed the columncomp branch 2 times, most recently from f3b3e32 to 9ad6477 Compare March 12, 2015 02:12
@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28491 has started for PR 4988 at commit f3b3e32.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28492 has started for PR 4988 at commit 9ad6477.

  • This patch merges cleanly.

rxin
rxin reviewed Mar 12, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/Column.scala Outdated
Copy link
Contributor

@rxin rxin Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't expr have its own hash code?

Copy link
Contributor Author

@vlyubin vlyubin Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does. Switched to use that.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28496 has started for PR 4988 at commit 92d7c8f.

  • This patch merges cleanly.

@rxin
Copy link
Contributor

rxin commented Mar 12, 2015

lgtm

@zsxwing
Copy link
Member

zsxwing commented Mar 12, 2015

I'm wondering if the meaning of equals in Column is precise, considering some Expressions does not implement equals.
Sorry that I misread the codes.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28491 has finished for PR 4988 at commit f3b3e32.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28491/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28492 has finished for PR 4988 at commit 9ad6477.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28492/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Mar 12, 2015

As far as I know all concrete expressions are case classes, which should be fine.

@SparkQA
Copy link

SparkQA commented Mar 12, 2015

Test build #28496 has finished for PR 4988 at commit 92d7c8f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28496/
Test PASSed.

@asfgit asfgit closed this in 25b71d8 Mar 12, 2015
asfgit pushed a commit that referenced this pull request Mar 12, 2015
@vlyubin @rxin
[SPARK-6296] [SQL] Added equals to Column
d9e141c 
Author: Volodymyr Lyubinets <vlyubin@gmail.com>

Closes #4988 from vlyubin/columncomp and squashes the following commits:

92d7c8f [Volodymyr Lyubinets] Added equals to Column

(cherry picked from commit 25b71d8)
Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vlyubin @SparkQA @sryza @rxin @AmplabJenkins @zsxwing