Skip to content

[SPARK-6326][SQL] Improve castStruct to be faster #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 2 commits into from
Closed

[SPARK-6326][SQL] Improve castStruct to be faster #5017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
746fcfb
Make castStruct faster.
viirya Mar 13, 2015
385d5b0
Further improved.
viirya Mar 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,17 @@ case class Cast(child: Expression, dataType: DataType) extends UnaryExpression w
val casts = from.fields.zip(to.fields).map {
case (fromField, toField) => cast(fromField.dataType, toField.dataType)
}
// TODO: This is very slow!
buildCast[Row](_, row => Row(row.toSeq.zip(casts).map {
case (v, cast) => if (v == null) null else cast(v)
}: _*))
// TODO: Could be faster?
val newRow = new GenericMutableRow(from.fields.size)
buildCast[Row](_, row => {
var i = 0
while (i < row.length) {
val v = row(i)
newRow.update(i, if (v == null) null else casts(i)(v))
Copy link
Contributor

@chenghao-intel chenghao-intel Mar 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: newRow(i) = if (v == null) null else casts(i)(v)

i += 1
}
newRow.copy()
Copy link
Contributor

@chenghao-intel chenghao-intel Mar 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just newRow should be OK.

Copy link
Member Author

@viirya viirya Mar 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the returned func has been called multiple times, wouldn't it cause problem?

Copy link
Contributor

@chenghao-intel chenghao-intel Mar 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only will be used within the Cast.eval I think, and the caller( e.g. in Join) will invoke the row.copy if necessary.

})
}

private[this] def cast(from: DataType, to: DataType): Any => Any = to match {
Expand Down