Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51407][CONNECT][DOCS] Document missed Spark Connect configurations #50171

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 5, 2025

What changes were proposed in this pull request?

This PR aims to documents the missed spark.connect.* configurations by syncing.

  • sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala
  • docs/configuration.md

Why are the changes needed?

Apache Spark 3.5.0

  • spark.connect.jvmStacktrace.maxSize
  • spark.sql.connect.ui.retainedSessions
  • spark.sql.connect.ui.retainedStatements

Apache Spark 4.0.0

  • spark.connect.grpc.binding.address
  • spark.connect.grpc.port.maxRetries
  • spark.connect.ml.backend.classes
  • spark.sql.connect.enrichError.enabled
  • spark.sql.connect.serverStacktrace.enabled
  • spark.connect.grpc.maxMetadataSize
  • spark.connect.progress.reportInterval

Does this PR introduce any user-facing change?

This updates only a config documentation and configuration HTML page.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-51407][CONNECT][DOCS] Document missed spark.connect.* configurations [SPARK-51407][CONNECT][DOCS] Document missed Spark Connect configurations Mar 5, 2025
<tr>
<td><code>spark.connect.jvmStacktrace.maxSize</code></td>
<td>
1024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is 1024 from Apache Spark 4.0.0 via the following while 2048 in Apache Spark 3.5.x

@dongjoon-hyun
Copy link
Member Author

Thank you, @allisonwang-db .

dongjoon-hyun added a commit that referenced this pull request Mar 5, 2025
…ations

### What changes were proposed in this pull request?

This PR aims to documents the missed `spark.connect.*` configurations by syncing.

- sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala
- docs/configuration.md

### Why are the changes needed?

**Apache Spark 3.5.0**
- spark.connect.jvmStacktrace.maxSize
- spark.sql.connect.ui.retainedSessions
- spark.sql.connect.ui.retainedStatements

**Apache Spark 4.0.0**
- spark.connect.grpc.binding.address
- spark.connect.grpc.port.maxRetries
- spark.connect.ml.backend.classes
- spark.sql.connect.enrichError.enabled
- spark.sql.connect.serverStacktrace.enabled
- spark.connect.grpc.maxMetadataSize
- spark.connect.progress.reportInterval

### Does this PR introduce _any_ user-facing change?

This updates only a config documentation and `configuration` HTML page.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #50171 from dongjoon-hyun/SPARK-51407.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 22f1905)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

Merged to master/4.0 for Apache Spark 4.0.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51407 branch March 5, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants