[SPARK-50983][SQL]Part 1.b Add analyzer support for nested correlated subqueries #50548
+298
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @agubichev |
vladimirg-db
reviewed
Apr 9, 2025
| "fields" -> plan.inputSet.map(f => toSQLId(f.name)).mkString(", ")) | ||
| ) | ||
| } | ||
| res |
There was a problem hiding this comment.
Do we need to extract nested outer aggs in UpdateOuterReferences?
| case other => | ||
| other.resolveChildren(nameParts, conf.resolver).map(wrapOuterReference) | ||
| val outerPlans = outerPlanContext.get | ||
| val resolvedExpressions = outerPlans.flatMap { |
There was a problem hiding this comment.
Shouldn't the resolution be backwards? From the lower outer plan to the upper. As far as I can see, the lower outer plan is the last one.
| @@ -25,16 +25,10 @@ import scala.collection.mutable.ArrayBuffer | |||
| import scala.jdk.CollectionConverters._ | |||
There was a problem hiding this comment.
Any chance to add SQL golden file tests just for Analyzed plans for this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for nested correlated subqueries.
Why are the changes needed?
Support for nested correlated subqueries.
Does this PR introduce any user-facing change?
How was this patch tested?
Current UT and Suite.
Was this patch authored or co-authored using generative AI tooling?
No