[SPARK-51773][SQL] Turn file formats into case classes to properly compare them #50562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
changed the title
mihailoale-db
approved these changes
Apr 11, 2025
HyukjinKwon
reviewed
Apr 13, 2025
| @@ -49,6 +49,10 @@ private[image] class ImageFileFormat extends FileFormat with DataSourceRegister | |||
|
|
|||
| override def shortName(): String = "image" | |||
|
|
|||
| override def hashCode(): Int = getClass.getCanonicalName.hashCode() | |||
|
|
|||
| override def equals(other: Any): Boolean = other.isInstanceOf[ImageFileFormat] | |||
There was a problem hiding this comment.
Hm, the options can be different. For example, dropInvalid can be enabled/disabled, which results in different outputs. Is this safe to assume that they are same?
There was a problem hiding this comment.
The options is not in the instance of ImageFileFormat
|
shall we simply turn them into case class? |
vladimirg-db
force-pushed
the
vladimir-golubev_data/add-hashcode-and-equals-to-file-formats
branch
from
8438735 to
2d2fa5c
Compare
vladimirg-db
changed the title
|
@cloud-fan hmm, might work, let me try that... |
cloud-fan
approved these changes
Apr 14, 2025
vladimirg-db
force-pushed
the
vladimir-golubev_data/add-hashcode-and-equals-to-file-formats
branch
from
2d2fa5c to
1724a56
Compare
|
@cloud-fan I'm getting a weird documentation generation failure... Does that seem familiar to you? |
cloud-fan
reviewed
Apr 15, 2025
sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 15, 2025
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
Show resolved
Hide resolved
github-actions
bot
added
STRUCTURED STREAMING
YARN
DOCS
CORE
INFRA
PYTHON
R
CONNECT
labels
vladimirg-db
force-pushed
the
vladimir-golubev_data/add-hashcode-and-equals-to-file-formats
branch
from
d349e91 to
85344e1
Compare
cloud-fan
reviewed
Apr 16, 2025
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 16, 2025
sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 16, 2025
mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMRelation.scala
Outdated
Show resolved
Hide resolved
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Turn file formats into case classes to properly compare them.
Why are the changes needed?
This is necessary to make
LogicalRelations comparable when comparing single-pass and fixed-point Analyzer results.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.