[SPARK-51849][SQL] Refactoring ResolveDDLCommandStringTypes
#50609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's file a JIRA and fill the PR description. Also would need a test |
ilicmarkodb
changed the title
ilicmarkodb
force-pushed
the
split_resolve_ddl_and_view
branch
from
b35621d to
6eaa310
Compare
ilicmarkodb
changed the title
ResolveDDLCommandStringTypes
| * can take various forms. | ||
| */ | ||
| object ResolveDDLCommandStringTypes extends Rule[LogicalPlan] { | ||
| object ApplyDefaultCollationToStringType extends Rule[LogicalPlan] { |
Contributor
There was a problem hiding this comment.
Wouldn't it make more sense to move this to the type coercion framework? Like CollationTypeCoercion?
Contributor
There was a problem hiding this comment.
Otherwise it's confusing - we are applying collations to string types in the CollationTypeCoercion, but for some reason the logic of applying a view-originated collation is in some separate rule outside.
ilicmarkodb
force-pushed
the
split_resolve_ddl_and_view
branch
from
8541c6a to
33bb12d
Compare
vladimirg-db
approved these changes
Apr 22, 2025
cloud-fan
approved these changes
Apr 22, 2025
Contributor
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 22, 2025
### What changes were proposed in this pull request? `ResolveDDLCommandStringTypes` renamed to `ApplyDefaultCollationToStringType`. ### Why are the changes needed? This is needed because this rule applies also to non-DDL plans (when querying View). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50609 from ilicmarkodb/split_resolve_ddl_and_view. Authored-by: ilicmarkodb <marko.ilic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c86f617) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
that referenced
this pull request
May 7, 2025
…efaultCollation should be consistent with transform ### What changes were proposed in this pull request? This is a followup of #50609 . `fetchDefaultCollation` should be consistent with `transform`, but now `fetchDefaultCollation` tries to get the table metadata from all ALTER TABLE commands, and custom v2 tables may have side effects when returning the table properties. This PR fixes it to only get table metadata for targeting commands that will be handled in `transform`. ### Why are the changes needed? fix potential regressions ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No Closes #50808 from cloud-fan/follow. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
that referenced
this pull request
May 7, 2025
…efaultCollation should be consistent with transform ### What changes were proposed in this pull request? This is a followup of #50609 . `fetchDefaultCollation` should be consistent with `transform`, but now `fetchDefaultCollation` tries to get the table metadata from all ALTER TABLE commands, and custom v2 tables may have side effects when returning the table properties. This PR fixes it to only get table metadata for targeting commands that will be handled in `transform`. ### Why are the changes needed? fix potential regressions ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No Closes #50808 from cloud-fan/follow. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 4574feb) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…efaultCollation should be consistent with transform ### What changes were proposed in this pull request? This is a followup of apache#50609 . `fetchDefaultCollation` should be consistent with `transform`, but now `fetchDefaultCollation` tries to get the table metadata from all ALTER TABLE commands, and custom v2 tables may have side effects when returning the table properties. This PR fixes it to only get table metadata for targeting commands that will be handled in `transform`. ### Why are the changes needed? fix potential regressions ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50808 from cloud-fan/follow. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? `ResolveDDLCommandStringTypes` renamed to `ApplyDefaultCollationToStringType`. ### Why are the changes needed? This is needed because this rule applies also to non-DDL plans (when querying View). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50609 from ilicmarkodb/split_resolve_ddl_and_view. Authored-by: ilicmarkodb <marko.ilic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 4c18f2d) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…efaultCollation should be consistent with transform ### What changes were proposed in this pull request? This is a followup of apache#50609 . `fetchDefaultCollation` should be consistent with `transform`, but now `fetchDefaultCollation` tries to get the table metadata from all ALTER TABLE commands, and custom v2 tables may have side effects when returning the table properties. This PR fixes it to only get table metadata for targeting commands that will be handled in `transform`. ### Why are the changes needed? fix potential regressions ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50808 from cloud-fan/follow. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 280977e) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ResolveDDLCommandStringTypesrenamed toApplyDefaultCollationToStringType.Why are the changes needed?
This is needed because this rule applies also to non-DDL plans (when querying View).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.