[SPARK-51937][SQL][TESTS] Re-generate golden files of postgreSQL/float4.sql and postgreSQL/int8.sql for Java 21
#50740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
LuciferYang
changed the title
postgreSQL/float4.sql and postgreSQL/int8.sql for Java 21.
LuciferYang
changed the title
postgreSQL/float4.sql and postgreSQL/int8.sql for Java 21.postgreSQL/float4.sql and postgreSQL/int8.sql for Java 21
Contributor
Author
dongjoon-hyun
approved these changes
Apr 28, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
LuciferYang
added a commit
that referenced
this pull request
Apr 28, 2025
…at4.sql` and `postgreSQL/int8.sql` for Java 21 ### What changes were proposed in this pull request? This pr aims to Re-generate golden files of `postgreSQL/float4.sql` and `postgreSQL/int8.sql` for Java 21. #50604 forgot to generate them. ### Why are the changes needed? Restore Java 21 daily test: - master: https://github.com/apache/spark/actions/runs/14699959163/job/41247643789 - branch-4.0: https://github.com/apache/spark/actions/runs/14700610338/job/41249373892   ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions - locally test with Java 21 ### Was this patch authored or co-authored using generative AI tooling? No Closes #50740 from LuciferYang/SPARK-51817-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit 6c37ee4) Signed-off-by: yangjie01 <yangjie01@baidu.com>
Contributor
Author
|
Merged into master/branch-4.0 to restore Java 21 daily test. Thanks @dongjoon-hyun |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…at4.sql` and `postgreSQL/int8.sql` for Java 21 ### What changes were proposed in this pull request? This pr aims to Re-generate golden files of `postgreSQL/float4.sql` and `postgreSQL/int8.sql` for Java 21. apache#50604 forgot to generate them. ### Why are the changes needed? Restore Java 21 daily test: - master: https://github.com/apache/spark/actions/runs/14699959163/job/41247643789 - branch-4.0: https://github.com/apache/spark/actions/runs/14700610338/job/41249373892   ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions - locally test with Java 21 ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50740 from LuciferYang/SPARK-51817-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…at4.sql` and `postgreSQL/int8.sql` for Java 21 ### What changes were proposed in this pull request? This pr aims to Re-generate golden files of `postgreSQL/float4.sql` and `postgreSQL/int8.sql` for Java 21. apache#50604 forgot to generate them. ### Why are the changes needed? Restore Java 21 daily test: - master: https://github.com/apache/spark/actions/runs/14699959163/job/41247643789 - branch-4.0: https://github.com/apache/spark/actions/runs/14700610338/job/41249373892   ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions - locally test with Java 21 ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50740 from LuciferYang/SPARK-51817-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit fb76a3d) Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to Re-generate golden files of
postgreSQL/float4.sqlandpostgreSQL/int8.sqlfor Java 21. #50604 forgot to generate them.Why are the changes needed?
Restore Java 21 daily test:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No