[SPARK-52023][SQL] Fix data corruption/segfault returning Option[Product] from udaf #50827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@eejbyfeldt this is a long standing correctness issue right? |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 1, 2025
…uct] from udaf ### What changes were proposed in this pull request? This fixes so defining a udaf returning a `Option[Product]` produces correct results instead of the current behavior. Where it throws an exception, segfaults or produces incorrect results. ### Why are the changes needed? Fix correctness issue. ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue. ### How was this patch tested? Existing and new unittest. ### Was this patch authored or co-authored using generative AI tooling? No Closes #50827 from eejbyfeldt/SPARK-52023. Authored-by: Emil Ejbyfeldt <emil.ejbyfeldt@choreograph.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 5e6e8f1) Signed-off-by: Herman van Hovell <herman@databricks.com>
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 1, 2025
…uct] from udaf ### What changes were proposed in this pull request? This fixes so defining a udaf returning a `Option[Product]` produces correct results instead of the current behavior. Where it throws an exception, segfaults or produces incorrect results. ### Why are the changes needed? Fix correctness issue. ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue. ### How was this patch tested? Existing and new unittest. ### Was this patch authored or co-authored using generative AI tooling? No Closes #50827 from eejbyfeldt/SPARK-52023. Authored-by: Emil Ejbyfeldt <emil.ejbyfeldt@choreograph.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 5e6e8f1) Signed-off-by: Herman van Hovell <herman@databricks.com>
Contributor
|
Merged to master/4.0/3.5 |
Member
|
Hi, @hvanhovell and @eejbyfeldt . Unfortunately, this broke Let me revert this. |
Member
|
This is reverted from branch-3.5 via a56879e Please make a backporting PR to branch-3.5 in order to make it passes the CI correctly at this time, @eejbyfeldt . |
eejbyfeldt
added a commit
to eejbyfeldt/spark
that referenced
this pull request
Jul 2, 2025
…uct] from udaf ### What changes were proposed in this pull request? This fixes so defining a udaf returning a `Option[Product]` produces correct results instead of the current behavior. Where it throws an exception, segfaults or produces incorrect results. ### Why are the changes needed? Fix correctness issue. ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue. ### How was this patch tested? Existing and new unittest. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50827 from eejbyfeldt/SPARK-52023. Authored-by: Emil Ejbyfeldt <emil.ejbyfeldt@choreograph.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
Contributor
Author
|
Thanks for taking care of the revert. Created this backport #51347 |
Contributor
Author
Yes, as far as I can tell it been there for along time. |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…uct] from udaf ### What changes were proposed in this pull request? This fixes so defining a udaf returning a `Option[Product]` produces correct results instead of the current behavior. Where it throws an exception, segfaults or produces incorrect results. ### Why are the changes needed? Fix correctness issue. ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue. ### How was this patch tested? Existing and new unittest. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50827 from eejbyfeldt/SPARK-52023. Authored-by: Emil Ejbyfeldt <emil.ejbyfeldt@choreograph.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit a08011b) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes so defining a udaf returning a
Option[Product]produces correct results instead of the current behavior. Where it throws an exception, segfaults or produces incorrect results.Why are the changes needed?
Fix correctness issue.
Does this PR introduce any user-facing change?
Fixes a correctness issue.
How was this patch tested?
Existing and new unittest.
Was this patch authored or co-authored using generative AI tooling?
No