Skip to content

[SPARK-53394][CORE] UninterruptibleLock.isInterruptible should avoid duplicated interrupt #52139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ngone51 wants to merge 5 commits into from
Closed

[SPARK-53394][CORE] UninterruptibleLock.isInterruptible should avoid duplicated interrupt #52139

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0c167f
fix
Ngone51 Aug 27, 2025
20e6bfb
comment
Ngone51 Aug 27, 2025
fbeb5aa
address comment
Ngone51 Aug 27, 2025
48dbe43
update comment
Ngone51 Aug 28, 2025
6d473d2
address comment
Ngone51 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ private[spark] class UninterruptibleThread(
// super.interrupt() is called. In this case to prevent runUninterruptibly() from being
// interrupted, we use awaitInterruptThread flag. We need to set it only if
// runUninterruptibly() is not yet set uninterruptible to true (!shouldInterruptThread) and
// there is no other threads that called interrupt (awaitInterruptThread is already true)
if (!shouldInterruptThread && !awaitInterruptThread) {
// there is no other threads that called interrupt (awaitInterruptThread is already true or
// isInterrupted is true. (SPARK-53394) Otherwise, the state of shouldInterruptThread would
// become inconsistent between isInterruptible() and isInterruptPending(), leading to
// UninterruptibleThread be interruptible under runUninterruptibly.)
if (!shouldInterruptThread && !awaitInterruptThread && !isInterrupted) {
awaitInterruptThread = true
true
} else {
Expand Down