[SPARK-53233][SQL][FOLLOWUP] Add compatibility class/object for org.apache.spark.sql.execution.streaming #52387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @cloud-fan . Could you fix the compilation failure?
[error] /home/runner/work/spark/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/legacy.scala:30:36: type mismatch;
[error] found : org.apache.hadoop.conf.Configuration
[error] required: org.apache.spark.sql.SparkSession
[error] extends ActualHDFSMetadataLog[T](conf, path) {
anishshri-db
approved these changes
Sep 19, 2025
Contributor
anishshri-db
left a comment
anishshri-db
left a comment
There was a problem hiding this comment.
Thanks for working on this !
HeartSaVioR
approved these changes
Sep 19, 2025
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1 assuming CI passes. Thanks for the work!
Contributor
Author
|
thanks for the review, merging to master! |
Contributor
|
late LGTM, thank you @cloud-fan |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…pache.spark.sql.execution.streaming ### What changes were proposed in this pull request? This is a followup of apache#51959 . Although internal APIs are allowed to be changed, it's still better to keep compatibility if possible to avoid breaking existing Spark plugins. This PR brings back `HDFSMetadataLog` and `SerializedOffset` to the original package, to avoid breaking the pulsar data source: https://github.com/streamnative/pulsar-spark/blob/master/src/main/scala/org/apache/spark/sql/pulsar/PulsarSources.scala#L27 ### Why are the changes needed? Avoid breaking Spark plugins ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? manual test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#52387 from cloud-fan/compat. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #51959 . Although internal APIs are allowed to be changed, it's still better to keep compatibility if possible to avoid breaking existing Spark plugins.
This PR brings back
HDFSMetadataLogandSerializedOffsetto the original package, to avoid breaking the pulsar data source: https://github.com/streamnative/pulsar-spark/blob/master/src/main/scala/org/apache/spark/sql/pulsar/PulsarSources.scala#L27Why are the changes needed?
Avoid breaking Spark plugins
Does this PR introduce any user-facing change?
No
How was this patch tested?
manual test
Was this patch authored or co-authored using generative AI tooling?
no