[SPARK-53773][SQL] Recover alphabetic ordering of rules in RuleIdCollection

[dongjoon-hyun]

What changes were proposed in this pull request?

This PR aims to recover alphabetic ordering of rules in RuleIdCollection class for Apache Spark 4.1.0.

Why are the changes needed?

Since rulesNeedingIds was originally defined to be in an alphabetic order like the following, we had better recover the ordering according to the original intention.

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala

Lines 43 to 44 in e04fd59

	// a changing, external state. Rules here are in alphabetical order.
	private var rulesNeedingIds: Seq[String] = {

Rules here are in alphabetical order.

Currently, (1) it has several outliers in terms of ordering and (2) the ordering is mixed with full class name and simple class name. For instance, AnsiCombinedTypeCoercionRule should be placed at the second if we consider simple class name. This PR makes it consistent via full name to fix the inconsistency including the following.

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala

Lines 57 to 59 in e04fd59

	"org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveFunctions" ::
	"org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveProcedures" ::
	"org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveGenerate" ::

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala

Lines 111 to 116 in e04fd59

	"org.apache.spark.sql.catalyst.analysis.ResolveUpdateEventTimeWatermarkColumn" ::
	"org.apache.spark.sql.catalyst.expressions.EliminatePipeOperators" ::
	"org.apache.spark.sql.catalyst.expressions.ValidateAndStripPipeExpressions" ::
	"org.apache.spark.sql.catalyst.analysis.ResolveUnresolvedHaving" ::
	"org.apache.spark.sql.catalyst.analysis.ResolveTableConstraints" ::
	"org.apache.spark.sql.catalyst.expressions.ExtractSemiStructuredFields" ::

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala

Lines 181 to 182 in e04fd59

	"org.apache.spark.sql.catalyst.optimizer.TransposeWindow" ::
	"org.apache.spark.sql.catalyst.optimizer.EvalInlineTables" ::

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala

Line 83 in e04fd59

"org.apache.spark.sql.catalyst.analysis.AnsiTypeCoercion$AnsiCombinedTypeCoercionRule" ::

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

[dongjoon-hyun]

cc @gengliangwang

[dongjoon-hyun]

Thank you, @peter-toth and @sarutak .

Merged to master for Apache Spark 4.1.0-preview3.

[gengliangwang]

Late LGTM 👍

[dongjoon-hyun]

Thank you, @gengliangwang !