[SPARK-54057][BUILD] Retrieve dependency version from pom.xml for DependencyOverrides in SparkBuild.scala
#52760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarutak
commented
Oct 28, 2025
| */ | ||
| object DependencyOverrides { | ||
| lazy val guavaVersion = sys.props.get("guava.version").getOrElse("33.4.0-jre") | ||
| lazy val jacksonVersion = sys.props.get("fasterxml.jackson.version").getOrElse("2.20.0") |
Member
Author
There was a problem hiding this comment.
I found it difficult to use sbt-pom-reader with here-sbt-bom so I leave lazy val jacksonVersion ... as it is for now.
Member
There was a problem hiding this comment.
Ah, I also was blocked by this during my previous attempts
pan3793
approved these changes
Oct 28, 2025
Member
|
Merged to master. |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Oct 30, 2025
…DependencyOverrides` in `SparkBuild.scala` ### What changes were proposed in this pull request? This PR proposes to retrieve dependency version from `pom.xml` for `DependencyOverrides` in `SparkBuild.scala`. ### Why are the changes needed? Currently, version strings for some dependencies are hard coded in `DependencyOverrides` in `SparkBuild`, so developers need to keep consistent with version strings specified in `pom.xml` manually. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52760 from sarutak/version-from-pom. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to retrieve dependency version from
pom.xmlforDependencyOverridesinSparkBuild.scala.Why are the changes needed?
Currently, version strings for some dependencies are hard coded in
DependencyOverridesinSparkBuild, so developers need to keep consistent with version strings specified inpom.xmlmanually.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.