Avoid traversing nested folders if recursiveFileLookup = false #52782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @mzhang thanks for the PR, can you file a JIRA for this and link the PR to it? See #52039 for an example of how we link JIRAs in PR titles. Also currently we use recursiveFileLookup to determine if we infer partitions from the directory schema rather than scan or not scan which is maybe a confusingly named parameter (see |
Contributor
Author
|
Hey! Thanks for taking a look! My mistake leaving this as reviewable - I wasn't sure if the CI would run otherwise but this PR wasn't ready for review yet. I will file a ticket per usual when I'm ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the in memory file index will list the non-direct children nodes of the input path, even if the recursiveFileLookup option is set to false, which can be very costly.
This PR skips the child node lookups.
Why are the changes needed?
These unnecessary lookups can be very costly.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No