[SPARK-54533][UI] Set metric ExecutorSource.METRIC_RESULT_SIZE with correct value#53243
Closed
jiwen624 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-54533][UI] Set metric ExecutorSource.METRIC_RESULT_SIZE with correct value#53243jiwen624 wants to merge 1 commit intoapache:masterfrom
jiwen624 wants to merge 1 commit intoapache:masterfrom
Conversation
jiwen624
changed the title
Contributor
Author
|
@cloud-fan @dongjoon-hyun could you take a look at this bug fix when you get a chance? Thanks |
jiwen624
changed the title
Contributor
|
is there a screenshot to demonstrate this "always 0" bug? |
Contributor
Author
|
@cloud-fan Here is the screenshot (yellow line - before fix, green line - after fix): I also attached another example of raw metrics reported before/after in the Jira (note the appId in the attached files are different from the screenshot above as they are from different runs) |
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Dec 2, 2025
…orrect value ### What changes were proposed in this pull request? Set the metric executorSource.METRIC_RESULT_SIZE after the result size is populated. ### Why are the changes needed? Currently the metric executorSource.METRIC_RESULT_SIZE is set to the value of `task.metrics.resultSize` which is always 0 in that line. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually tested on local Spark. See the Jira attachments for metrics reported before and after fix. ### Was this patch authored or co-authored using generative AI tooling? No Closes #53243 from jiwen624/executor-source-result-size. Authored-by: Eric Yang <jiwen624@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 769ccc6) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Member
|
Thank you, @jiwen624 and @cloud-fan . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set the metric executorSource.METRIC_RESULT_SIZE after the result size is populated.
Why are the changes needed?
Currently the metric executorSource.METRIC_RESULT_SIZE is set to the value of
task.metrics.resultSizewhich is always 0 in that line.Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested on local Spark. See the Jira attachments for metrics reported before and after fix.
Was this patch authored or co-authored using generative AI tooling?
No