[SPARK-54627][PYTHON] Remove redundant initializations in serializers #53368
+5
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaogaotiantian
approved these changes
Dec 6, 2025
HyukjinKwon
approved these changes
Dec 7, 2025
Member
|
Merged to master. |
xu20160924
pushed a commit
to xu20160924/spark
that referenced
this pull request
Dec 9, 2025
### What changes were proposed in this pull request? Remove redundant `self._timezone` and `self._safecheck` assignments in three serializer classes (`ArrowStreamAggArrowUDFSerializer`, `ArrowStreamAggArrowIterUDFSerializer`, `ArrowStreamAggPandasUDFSerializer`). Also improve parameter passing by directly passing `assign_cols_by_name` and `arrow_cast` to parent class instead of passing fixed values and then overriding them. ### Why are the changes needed? Improves code clarity and consistency by removing redundant code that was already set by parent classes. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Ran existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53368 from Yicong-Huang/SPARK-54627/refactor/remove-redundant-initializations. Authored-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove redundant
self._timezoneandself._safecheckassignments in three serializer classes (ArrowStreamAggArrowUDFSerializer,ArrowStreamAggArrowIterUDFSerializer,ArrowStreamAggPandasUDFSerializer).Also improve parameter passing by directly passing
assign_cols_by_nameandarrow_castto parent class instead of passing fixed values and then overriding them.Why are the changes needed?
Improves code clarity and consistency by removing redundant code that was already set by parent classes.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.