[SPARK-54631][PYTHON] Add profiler support for Arrow Grouped Iter Aggregate UDF #53374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 7, 2025
Member
|
Merged to master. |
xu20160924
pushed a commit
to xu20160924/spark
that referenced
this pull request
Dec 9, 2025
…regate UDF ### What changes were proposed in this pull request? - `spark.python.profile`: Add `SQL_GROUPED_AGG_ARROW_ITER_UDF` to the profiler warning list in `udf.py` so that when `spark.python.profile` is enabled, users will see appropriate warnings consistent with other iterator-based UDFs. - `spark.sql.pyspark.udf.profiler`: No changes needed. This UDF type already works correctly because it returns scalar (not iterator), so it uses the non-iterator profiler branch in `wrap_perf_profiler` and `wrap_memory_profiler`. ### Why are the changes needed? To make profilers support for `SQL_GROUPED_AGG_ARROW_ITER_UDF` consistent with other UDFs. ### Does this PR introduce _any_ user-facing change? Yes. When users enable `spark.python.profile` with `SQL_GROUPED_AGG_ARROW_ITER_UDF`, they will now see a warning message consistent with other iterator-based UDFs. ### How was this patch tested? Added a test case `test_perf_profiler_arrow_udf_grouped_agg_iter` to verify that `spark.sql.pyspark.udf.profiler` works correctly with this UDF type. Also verified that the `spark.python.profile` profiler warning is triggered correctly in `test_unsupported`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53374 from Yicong-Huang/SPARK-54631/feat/add-profiler-support-for-arrow-grouped-agg-iter-udf. Authored-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark.python.profile: AddSQL_GROUPED_AGG_ARROW_ITER_UDFto the profiler warning list inudf.pyso that whenspark.python.profileis enabled, users will see appropriate warnings consistent with other iterator-based UDFs.spark.sql.pyspark.udf.profiler: No changes needed. This UDF type already works correctly because it returns scalar (not iterator), so it uses the non-iterator profiler branch inwrap_perf_profilerandwrap_memory_profiler.Why are the changes needed?
To make profilers support for
SQL_GROUPED_AGG_ARROW_ITER_UDFconsistent with other UDFs.Does this PR introduce any user-facing change?
Yes. When users enable
spark.python.profilewithSQL_GROUPED_AGG_ARROW_ITER_UDF, they will now see a warning message consistent with other iterator-based UDFs.How was this patch tested?
Added a test case
test_perf_profiler_arrow_udf_grouped_agg_iterto verify thatspark.sql.pyspark.udf.profilerworks correctly with this UDF type. Also verified that thespark.python.profileprofiler warning is triggered correctly intest_unsupported.Was this patch authored or co-authored using generative AI tooling?
No.