[SPARK-54638][SQL][TEST] Reuse statement instances if possible in SparkConnectJdbcDataTypeSuite
#53385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
LGTM, but you may want to merge this one after #53371, from a new contributor, suppose the author can quickly address the comments |
dongjoon-hyun
approved these changes
Dec 8, 2025
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @cloud-fan and @pan3793 .
I'm going to land this first. Pending CIs.
Member
|
To @cloud-fan , please fix the linter failure. |
dongjoon-hyun
changed the title
SparkConnectJdbcDataTypeSuite
dongjoon-hyun
changed the title
SparkConnectJdbcDataTypeSuiteSparkConnectJdbcDataTypeSuite
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 8, 2025
…arkConnectJdbcDataTypeSuite` ### What changes were proposed in this pull request? Improve `SparkConnectJdbcDataTypeSuite` to reuse the statement instances in `withExecuteQuery` if possible ### Why are the changes needed? use less resources in tests ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? cursor 2.1.50 Closes #53385 from cloud-fan/test. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit ce9dcab) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/4.1 for Apache Spark 4.1.0. |
xu20160924
pushed a commit
to xu20160924/spark
that referenced
this pull request
Dec 9, 2025
…arkConnectJdbcDataTypeSuite` Improve `SparkConnectJdbcDataTypeSuite` to reuse the statement instances in `withExecuteQuery` if possible use less resources in tests no existing tests cursor 2.1.50 Closes apache#53385 from cloud-fan/test. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve
SparkConnectJdbcDataTypeSuiteto reuse the statement instances inwithExecuteQueryif possibleWhy are the changes needed?
use less resources in tests
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
cursor 2.1.50