[SPARK-54644][PYTHON][SS][TESTS] Always stop the query before await it#53394
Closed
gaogaotiantian wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-54644][PYTHON][SS][TESTS] Always stop the query before await it#53394gaogaotiantian wants to merge 1 commit intoapache:masterfrom
gaogaotiantian wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Dec 8, 2025
HyukjinKwon
changed the title
Member
|
Merged to master. |
Contributor
Author
|
Comparing https://github.com/apache/spark/actions/runs/20059639733/job/57533318524 with https://github.com/apache/spark/actions/runs/20129390796/job/57766978256, we saved more than 40 minutes per run with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have patterns like
which will make the test wait for 10 seconds to timeout - it is such a waste and it's causing our daily coverage run to timeout. We should
stop()the query beforeawaitTerminationand save these 10 seconds - there are a lot of them.Why are the changes needed?
It's a waste time and it's causing our CIs to timeout.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally it runs much faster (without the unnecessary wait).
Was this patch authored or co-authored using generative AI tooling?