[SPARK-6262][MLLIB]Implement missing methods for MultivariateStatisticalSummary #5359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lewuathe
changed the title
|
Test PASSed. |
Contributor
|
LGTM. Merged into master. @Lewuathe There is a minor issue with your test. It doesn't actually test normL1 and normL2 but just the size of the output. We can create a RDD like Could you submit another PR and update the test? Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Apr 7, 2015
…for normL1... ... and normL2. Add test cases to insufficient unit test for `normL1` and `normL2`. Ref: #5359 Author: lewuathe <lewuathe@me.com> Closes #5374 from Lewuathe/SPARK-6720 and squashes the following commits: 5541b24 [lewuathe] More accurate tests dc5718c [lewuathe] [SPARK-6720] PySpark MultivariateStatisticalSummary unit test for normL1 and normL2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add below methods in pyspark for MultivariateStatisticalSummary