[SPARK-54851][BUILD] Support generating bloop files via sbt #53621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for generating Bloop configuration files via sbt to improve IDE integration for tools like Cursor and VSCode. The changes enable developers to use Bloop as a build server for better IDE support.
Key Changes:
- Added sbt-bloop plugin dependency (version 2.0.17)
- Extended ExcludeShims object to filter Bloop's internal classpath, ensuring connect-shims modules are excluded consistently with the existing classpath filtering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| project/plugins.sbt | Adds the sbt-bloop plugin dependency for generating Bloop configuration files |
| project/SparkBuild.scala | Implements Bloop classpath filtering logic in the ExcludeShims object to maintain consistency with existing classpath exclusions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
May I know this change is for sbt running in shell or in IDE extensions |
yaooqinn
approved these changes
Dec 26, 2025
Contributor
Author
|
It's for cursor/vscode to import Spark using bloop. |
Contributor
Author
|
thanks for review, merging to master/4.1! (sbt build is dev only, not affect production code) |
cloud-fan
added a commit
that referenced
this pull request
Dec 27, 2025
### What changes were proposed in this pull request? Some IDEs such as cursor/VSCode works better with bloop as the build server. This PR supports generating the bloop config files via sbt. ### Why are the changes needed? better IDE support ### Does this PR introduce _any_ user-facing change? no, dev only ### How was this patch tested? manual test ### Was this patch authored or co-authored using generative AI tooling? cursor 2.2.43 Closes #53621 from cloud-fan/bloop. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit eec092c) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some IDEs such as cursor/VSCode works better with bloop as the build server. This PR supports generating the bloop config files via sbt.
Why are the changes needed?
better IDE support
Does this PR introduce any user-facing change?
no, dev only
How was this patch tested?
manual test
Was this patch authored or co-authored using generative AI tooling?
cursor 2.2.43