Skip to content

[SPARK-6765] Fix test code style for mllib. #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 1 commit into from
Closed

[SPARK-6765] Fix test code style for mllib. #5411

rxin wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 8, 2015

So we can turn style checker on for test code.

@rxin
[SPARK-6765] Fix test code style for mllib.
d8a2569 
So we can turn style checker on for test code.
@mengxr
Copy link
Contributor

mengxr commented Apr 8, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29839 has started for PR 5411 at commit d8a2569.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29839 has finished for PR 5411 at commit d8a2569.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 8, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29839/
Test PASSed.

@asfgit asfgit closed this in 66159c3 Apr 8, 2015
@rxin rxin mentioned this pull request Apr 13, 2015
Closed
asfgit pushed a commit that referenced this pull request Apr 13, 2015
@rxin
[SPARK-6765] Enable scalastyle on test code.
c5b0b29 
Turn scalastyle on for all test code. Most of the violations have been resolved in my previous pull requests:

Core: #5484
SQL: #5412
MLlib: #5411
GraphX: #5410
Streaming: #5409

Author: Reynold Xin <rxin@databricks.com>

Closes #5486 from rxin/test-style-enable and squashes the following commits:

01683de [Reynold Xin] Fixed new code.
a4ab46e [Reynold Xin] Fixed tests.
20adbc8 [Reynold Xin] Missed one violation.
5e36521 [Reynold Xin] [SPARK-6765] Enable scalastyle on test code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @mengxr @SparkQA @AmplabJenkins