Skip to content

[SPARK-7044] [SQL] Fix the deadlock in script transformation #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chenghao-intel wants to merge 1 commit into from
Closed

[SPARK-7044] [SQL] Fix the deadlock in script transformation #5625

chenghao-intel wants to merge 1 commit into from

Conversation

@chenghao-intel
Copy link
Contributor

@chenghao-intel chenghao-intel commented Apr 22, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Apr 22, 2015

Test build #30728 has finished for PR 5625 at commit 885685a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Apr 23, 2015

cc @marmbrus @yhuai , this is actually a critical bug introduced by #4014, the BigBench is blocked by this.

rxin
rxin reviewed Apr 23, 2015
View reviewed changes
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala Outdated
Copy link
Contributor

@rxin rxin Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just create a new thread to run this? seems wrong to use a global shared thread pool

Copy link
Contributor Author

@chenghao-intel chenghao-intel Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rxin, I think you are right, updated!

@SparkQA
Copy link

SparkQA commented Apr 23, 2015

Test build #30847 has finished for PR 5625 at commit 5ec1dd2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor

rxin commented Apr 23, 2015

Merging in master & branch-1.3.

@asfgit asfgit closed this in cc48e63 Apr 23, 2015
@rxin
Copy link
Contributor

rxin commented Apr 23, 2015

Actually this doesn't merge cleanly into 1.3. Do you mind submitting a pull request for that branch? Thanks.

@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Apr 24, 2015

Thank you @rxin. I've created another PR #5671 for backporting to 1.3, let's wait for the testing result.

@chenghao-intel chenghao-intel deleted the transform branch April 24, 2015 01:03
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
@chenghao-intel
[SPARK-7044] [SQL] Fix the deadlock in script transformation
3c2cb4b 
Author: Cheng Hao <hao.cheng@intel.com>

Closes apache#5625 from chenghao-intel/transform and squashes the following commits:

5ec1dd2 [Cheng Hao] fix the deadlock issue in ScriptTransform
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@chenghao-intel @nemccarthy
[SPARK-7044] [SQL] Fix the deadlock in script transformation
f722d5e 
Author: Cheng Hao <hao.cheng@intel.com>

Closes apache#5625 from chenghao-intel/transform and squashes the following commits:

5ec1dd2 [Cheng Hao] fix the deadlock issue in ScriptTransform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenghao-intel @SparkQA @rxin