Skip to content

[SPARK-7070][MLLIB] LDA.setBeta should call setTopicConcentration. #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mengxr wants to merge 1 commit into from
Closed

[SPARK-7070][MLLIB] LDA.setBeta should call setTopicConcentration. #5649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/clustering/LDA.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class LDA private (
def getBeta: Double = getTopicConcentration

/** Alias for [[setTopicConcentration()]] */
def setBeta(beta: Double): this.type = setBeta(beta)
def setBeta(beta: Double): this.type = setTopicConcentration(beta)

/**
* Maximum number of iterations for learning.
Expand Down
8 changes: 8 additions & 0 deletions mllib/src/test/scala/org/apache/spark/mllib/clustering/LDASuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,14 @@ class LDASuite extends FunSuite with MLlibTestSparkContext {
assert(termVertexIds.map(i => LDA.index2term(i.toLong)) === termIds)
assert(termVertexIds.forall(i => LDA.isTermVertex((i.toLong, 0))))
}

test("setter alias") {
val lda = new LDA().setAlpha(2.0).setBeta(3.0)
assert(lda.getAlpha === 2.0)
assert(lda.getDocConcentration === 2.0)
assert(lda.getBeta === 3.0)
assert(lda.getTopicConcentration === 3.0)
}
}

private[clustering] object LDASuite {
Expand Down