-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-6014] [core][hotfix] Add try-catch block around ShutDownHook #5672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
681b36f
Fix for SPARK-1758: failing test org.apache.spark.JavaAPISuite.wholeT…
nishkamravi2 5108700
Fix in Spark for the Concurrent thread modification issue (SPARK-1097…
nishkamravi2 6b840f0
Undo the fix for SPARK-1758 (the problem is fixed)
nishkamravi2 df2aeb1
Improved fix for ConcurrentModificationIssue (Spark-1097, Hadoop-10456)
nishkamravi2 eb663ca
Merge branch 'master' of https://github.com/apache/spark
nishkamravi2 5423a03
Merge branch 'master' of https://github.com/apache/spark
nishkamravi2 3bf8fad
Merge branch 'master' of https://github.com/apache/spark
nishkamravi2 2b630f9
Accept memory input as "30g", "512M" instead of an int value, to be c…
nishkamravi2 efd688a
Merge branch 'master' of https://github.com/apache/spark
nishkamravi2 2e69f11
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 ebcde10
Modify default YARN memory_overhead-- from an additive constant to a …
nishkamravi2 1cf2d1e
Update YarnAllocator.scala
nishkamravi2 f00fa31
Improving logging for AM memoryOverhead
nishkamravi2 c726bd9
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 362da5e
Additional changes for yarn memory overhead
nishkamravi2 42c2c3d
Additional changes for yarn memory overhead issue
nishkamravi2 dac1047
Additional documentation for yarn memory overhead issue
nishkamravi2 5ac2ec1
Remove out
nishkamravi2 35daa64
Slight change in the doc for yarn memory overhead
nishkamravi2 8f76c8b
Doc change for yarn memory overhead
nishkamravi2 636a9ff
Update YarnAllocator.scala
nishkamravi2 5f8f9ed
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 9f6583e
Changes to maxResultSize code (improve error message and add conditio…
nishkamravi2 3e1b616
Modify test for maxResultSize
nishkamravi2 535295a
Update TaskSetManager.scala
nishkamravi2 5c9a4cb
Update TaskSetManagerSuite.scala
nishkamravi2 b446edc
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 79ea8b4
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 f0d12de
Workaround for IllegalStateException caused by recent changes to Bloc…
nishkamravi2 3c5ddba
Update DiskBlockManager.scala
nishkamravi2 494d8c0
Update DiskBlockManager.scala
nishkamravi2 71d0e17
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 ba1eb8b
Try-catch block around the two occurrences of removeShutDownHook. Del…
nishkamravi2 f7e33c2
Merge branch 'master_nravi' of https://github.com/nishkamravi2/spark …
nishkamravi2 0ce2c32
Update HadoopRDD.scala
nishkamravi2 6f41a1d
Update NewHadoopRDD.scala
nishkamravi2 d453197
Update NewHadoopRDD.scala
nishkamravi2 ee902fa
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 bfe96e0
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 746f35b
"hadoop" string in the assembly name should not be mandatory (everywh…
nishkamravi2 4bd4489
Update AbstractCommandBuilder.java
nishkamravi2 32c3ab3
Update AbstractCommandBuilder.java
nishkamravi2 35af990
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 06bfeb0
Update spark-class
nishkamravi2 ac58975
spark-class changes
nishkamravi2 345206a
spark-class merge
nishkamravi2 3faa7a4
Launcher library changes (SPARK-6406)
nishkamravi2 ccdc334
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 d9658d6
Changes for SPARK-6406
nishkamravi2 458af39
Locate the jar using getLocation, obviates the need to pass assembly …
nishkamravi2 4a45d6a
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 b7f4ae7
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 36a6f87
Minor changes and bug fixes
nishkamravi2 bad4349
Update Main.java
nishkamravi2 1c13b79
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 2be1e76
Merge branch 'master' of https://github.com/apache/spark into master_…
nishkamravi2 8691e0c
Add a try/catch block around Utils.removeShutdownHook
nishkamravi2 97c383e
Update Utils.scala
nishkamravi2 474e3bf
Update DiskBlockManager.scala
nishkamravi2 0f1abd0
Update Utils.scala
nishkamravi2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this simply not throw an exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would it do instead? Just ignore the call and return
false?Probably not a big deal in practice, but it does overload the return value to mean "either the hook doesn't exist, or I can't remove it at this time".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Asking to remove a hook always races with shutdown, so I suppose code can never guarantee it's been able to remove a hook before shutdown. It can't be sure it has successfully removed the hook before it executes. So it doesn't seem to bad to just try to remove the hook, which might or might not have executed and discarded already, and return normally either way. That is do you want to prohibit removal of a hook that hasn't run, even during shutdown? meh, might be a simpler way to resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. It should be ok to allow removing the hooks during shutdown.
SparkShutdownHookManager.runAllis safe against modifications to the underlying queue.