SPARK-5529 Backported changes to 1.3 #5747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Author
|
Locally the tests are taking for ever to complete. Seems like everything is working as intended so far. |
Member
|
#4363 right? That looks pretty close, but it's not from a cherry-pick. For example it misses the docs change, and the indentation is wrong. Usually you back-port by starting from a cherry-pick of the original commit into the branch and massage it from there. Can you have a run at it that way? it will also preserve more of the connection to the original and avoid making the branches diverge more than needed, even if in small ways. |
Author
|
I started out with a cherry-pick originally, however it did not apply cleanly for some reason. Seemed to work this time around. Here is the new pull: #5793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about all the previous pull requests. Still running tests on this branch. Mechanically applied the changes based on #4369 without fully understanding whats actually happening since I am not familiar with the codebase. Feedback would be appreciated.