Skip to content

Conversation

@cfregly
Copy link
Contributor

@cfregly cfregly commented May 4, 2015

...separate from Kinesis region (or use the same), ability to pass in AWS credentials and not rely on EC2 IAM roles and other environment settings that may be difficult to set otherwise, ability to override appName for environments that provide you an existing SparkContext/SparkConf where the appName is already set (ie. Spark Shell)

@tdas (and others): please review. thanks!

…on separate from Kinesis region (or use the same), ability to pass in AWS credentials and not rely on EC2 IAM roles and other environment settings that may be difficult to set otherwise, ability to override appName for environments that provide you an existing SparkContext/SparkConf where the appName is already set (ie. Spark Shell)
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@tdas
Copy link
Contributor

tdas commented May 5, 2015

This is ok to test

@tdas
Copy link
Contributor

tdas commented May 6, 2015

ok to test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Instances of this class will be shipped to the executors"

@tdas
Copy link
Contributor

tdas commented May 6, 2015

ok to test.

@tdas
Copy link
Contributor

tdas commented May 6, 2015

Jenkins, this is ok to test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is in the 100 character limit?

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not let the awsAccessKey be printed, and not the secret key?

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32051 has started for PR 5882 at commit 2853cb0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this formatting seems messed up. This PR requires a huge formatting overhaul.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naah correction, it may not be. My screen resolution was messed up which made all the lines wrap and look messed up.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32051 has finished for PR 5882 at commit 2853cb0.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class BasicAWSCredentialsProvider(awsAccessKeyId: String, awsSecretKey: String)

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32051/
Test FAILed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra indent in these comment lines

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@tdas
Copy link
Contributor

tdas commented May 13, 2015

@cfregly Mind if I take over this PR? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete this file??

@tdas
Copy link
Contributor

tdas commented May 18, 2015

@cfregly Thanks for all the work for this PR. I merge the fixed up version of this. Mind closing this PR.

@cfregly cfregly closed this May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants