-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-6514][SPARK-5960][SPARK-6656] Ability to specify DynamoDB region ... #5882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on separate from Kinesis region (or use the same), ability to pass in AWS credentials and not rely on EC2 IAM roles and other environment settings that may be difficult to set otherwise, ability to override appName for environments that provide you an existing SparkContext/SparkConf where the appName is already set (ie. Spark Shell)
|
Can one of the admins verify this patch? |
|
This is ok to test |
|
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Instances of this class will be shipped to the executors"
|
ok to test. |
|
Jenkins, this is ok to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is in the 100 character limit?
|
Merged build triggered. |
|
Merged build started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not let the awsAccessKey be printed, and not the secret key?
|
Test build #32051 has started for PR 5882 at commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this formatting seems messed up. This PR requires a huge formatting overhaul.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naah correction, it may not be. My screen resolution was messed up which made all the lines wrap and look messed up.
|
Test build #32051 has finished for PR 5882 at commit
|
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the extra indent in these comment lines
|
Can one of the admins verify this patch? |
|
@cfregly Mind if I take over this PR? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you delete this file??
|
@cfregly Thanks for all the work for this PR. I merge the fixed up version of this. Mind closing this PR. |
...separate from Kinesis region (or use the same), ability to pass in AWS credentials and not rely on EC2 IAM roles and other environment settings that may be difficult to set otherwise, ability to override appName for environments that provide you an existing SparkContext/SparkConf where the appName is already set (ie. Spark Shell)
@tdas (and others): please review. thanks!