-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-7478][SQL] Added SQLContext.getOrCreate #6006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bc72868
Added SQLContext.getOrCreate
tdas f82ae81
Fixed test
tdas 83bc950
Updated tests
tdas d3ea8e4
Added HiveContext
tdas 4ef513b
Merge remote-tracking branch 'apache-github/master' into SPARK-7478
tdas b4e9721
Remove unnecessary import
tdas dec5594
Fixed bug
tdas bf8cf50
Fix more bug
tdas 48adb14
Removed HiveContext.getOrCreate
tdas c66ca76
Merge remote-tracking branch 'apache-github/master' into SPARK-7478
tdas 79fe069
Added comments.
tdas 25f4da9
Addressed comments.
tdas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql | ||
|
|
||
| import org.scalatest.{BeforeAndAfterAll, FunSuite} | ||
|
|
||
| import org.apache.spark.sql.test.TestSQLContext | ||
|
|
||
| class SQLContextSuite extends FunSuite with BeforeAndAfterAll { | ||
|
|
||
| private val testSqlContext = TestSQLContext | ||
| private val testSparkContext = TestSQLContext.sparkContext | ||
|
|
||
| override def afterAll(): Unit = { | ||
| SQLContext.setLastInstantiatedContext(testSqlContext) | ||
| } | ||
|
|
||
| test("getOrCreate instantiates SQLContext") { | ||
| SQLContext.clearLastInstantiatedContext() | ||
| val sqlContext = SQLContext.getOrCreate(testSparkContext) | ||
| assert(sqlContext != null, "SQLContext.getOrCreate returned null") | ||
| assert(SQLContext.getOrCreate(testSparkContext).eq(sqlContext), | ||
| "SQLContext created by SQLContext.getOrCreate not returned by SQLContext.getOrCreate") | ||
| } | ||
|
|
||
| test("getOrCreate gets last explicitly instantiated SQLContext") { | ||
| SQLContext.clearLastInstantiatedContext() | ||
| val sqlContext = new SQLContext(testSparkContext) | ||
| assert(SQLContext.getOrCreate(testSparkContext) != null, | ||
| "SQLContext.getOrCreate after explicitly created SQLContext returned null") | ||
| assert(SQLContext.getOrCreate(testSparkContext).eq(sqlContext), | ||
| "SQLContext.getOrCreate after explicitly created SQLContext did not return the context") | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rxin Design question. Should contexts created directly (that is, not through
getOrCreate) also be automatically considered for the singleton?