-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-7579 [ML] [DOC] User guide update for OneHotEncoder #6126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Merged build triggered. |
|
Merged build started. |
|
Test build #32634 has started for PR 6126 at commit |
|
Test build #32634 has finished for PR 6126 at commit
|
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
docs/ml-features.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add something like, "This encoding allows algorithms which expect continuous features to use categorical features as well; for example Logistic Regression requires continuous features, but it can use categorical features after one-hot encoding."
Could you please add a Wikipedia link? [http://en.wikipedia.org/wiki/One-hot]
"the includeFirst" --> "the includeFirst parameter"
|
@sryza Thanks for the PR! Can you please add tags "[ml]" (not mllib) and "[doc]" to the title? Also, a Python API has been added, so could you please add a Python example? |
|
Merged build triggered. |
|
Merged build started. |
|
Test build #32724 has started for PR 6126 at commit |
|
Test build #32724 has finished for PR 6126 at commit
|
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
docs/ml-features.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need {% endhighlight %}
Q: Have you tried generating this using jekyll? This is the only issue I spotted. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posting a patch that fixes this. My jekyll efforts have been thwarted with errors like:
/home/sandy/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala:318: polymorphic expression cannot be instantiated to expected type;
Any idea how to get past these?
|
Build triggered. |
|
Build started. |
|
Test build #33101 has started for PR 6126 at commit |
|
Merged build triggered. |
|
Merged build started. |
|
Test build #33102 has started for PR 6126 at commit |
|
Test build #33102 has finished for PR 6126 at commit
|
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Test build #33101 has finished for PR 6126 at commit
|
|
Build finished. Test PASSed. |
|
Test PASSed. |
|
@sryza The unclean merge is probably from another feature transformer PR, but it should be easy to fix. I'm not sure about the jekyll issue; I haven't seen that happen. The only thing I know to recommend is the usual: Check jekyll version (I'm using 2.4.0), and do a clean build. If you can't get it to work, I can check on my side too. |
|
The unclean merge is fixed in the current version of the patch. Re: Jekyll, can try a clean build tomorrow. |
|
Hm, the last test says the merge is unclean. |
|
Test build #835 has started for PR 6126 at commit |
|
Test build #835 has finished for PR 6126 at commit
|
|
LGTM merging into master and branch-1.4 |
Author: Sandy Ryza <sandy@cloudera.com> Closes #6126 from sryza/sandy-spark-7579 and squashes the following commits: 5af803d [Sandy Ryza] SPARK-7579 [MLLIB] User guide update for OneHotEncoder (cherry picked from commit 829f1d9) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Author: Sandy Ryza <sandy@cloudera.com> Closes apache#6126 from sryza/sandy-spark-7579 and squashes the following commits: 5af803d [Sandy Ryza] SPARK-7579 [MLLIB] User guide update for OneHotEncoder
Author: Sandy Ryza <sandy@cloudera.com> Closes apache#6126 from sryza/sandy-spark-7579 and squashes the following commits: 5af803d [Sandy Ryza] SPARK-7579 [MLLIB] User guide update for OneHotEncoder
Author: Sandy Ryza <sandy@cloudera.com> Closes apache#6126 from sryza/sandy-spark-7579 and squashes the following commits: 5af803d [Sandy Ryza] SPARK-7579 [MLLIB] User guide update for OneHotEncoder
No description provided.