Skip to content

[SQL][Minor] Skip unresolved expression for InConversion #6145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scwf wants to merge 1 commit into from
Closed

[SQL][Minor] Skip unresolved expression for InConversion #6145

scwf wants to merge 1 commit into from

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented May 14, 2015

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 14, 2015

Test build #32705 has started for PR 6145 at commit 5c8ac6b.

@SparkQA
Copy link

SparkQA commented May 14, 2015

Test build #32705 has finished for PR 6145 at commit 5c8ac6b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32705/
Test FAILed.

@scwf
Copy link
Contributor Author

scwf commented May 14, 2015

Retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 14, 2015

Test build #32747 has started for PR 6145 at commit 5c8ac6b.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32747 has finished for PR 6145 at commit 5c8ac6b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 15, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 15, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32747/
Test PASSed.

@scwf
Copy link
Contributor Author

scwf commented May 17, 2015

/cc @liancheng

@liancheng
Copy link
Contributor

liancheng commented May 17, 2015

Would you mind to add a test case for this? Otherwise LGTM, thanks!

@liancheng
Copy link
Contributor

liancheng commented May 17, 2015

The added clause makes the code path safer, but for now I couldn't think of a test case that makes the original code fail... I still tend to have this though.

@scwf
Copy link
Contributor Author

scwf commented May 17, 2015

yes, actually it is hard to give a test case for now, i met this issue on my inner branch with a tpcds sql.
that sql is invalid on the master branch so i can not add a test now.

@liancheng
Copy link
Contributor

liancheng commented May 17, 2015

I see. I'm merging this to master since it looks pretty safe.

@asfgit asfgit closed this in edf09ea May 17, 2015
@scwf scwf deleted the InConversion branch May 17, 2015 08:31
@scwf
Copy link
Contributor Author

scwf commented May 17, 2015

@liancheng should this fix merge to branch-1.4 also?

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@scwf @jeanlyn
[SQL] [MINOR] Skip unresolved expression for InConversion
9cd10bd 
Author: scwf <wangfei1@huawei.com>

Closes apache#6145 from scwf/InConversion and squashes the following commits:

5c8ac6b [scwf] minir fix for InConversion
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@scwf @jeanlyn
[SQL] [MINOR] Skip unresolved expression for InConversion
8d817d9 
Author: scwf <wangfei1@huawei.com>

Closes apache#6145 from scwf/InConversion and squashes the following commits:

5c8ac6b [scwf] minir fix for InConversion
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@scwf @nemccarthy
[SQL] [MINOR] Skip unresolved expression for InConversion
37e013b 
Author: scwf <wangfei1@huawei.com>

Closes apache#6145 from scwf/InConversion and squashes the following commits:

5c8ac6b [scwf] minir fix for InConversion
@cloud-fan
Copy link
Contributor

cloud-fan commented Jun 26, 2015

Found a test case for you...
https://issues.apache.org/jira/browse/SPARK-8588
And we should merge this fix into branch 1.4. cc @marmbrus @liancheng

@liancheng
Copy link
Contributor

liancheng commented Jun 29, 2015

@scwf @cloud-fan Thanks! I'm merging this to branch-1.4.

asfgit pushed a commit that referenced this pull request Jun 29, 2015
@scwf @liancheng
[SQL] [MINOR] Skip unresolved expression for InConversion
457d07e 
Author: scwf <wangfei1@huawei.com>

Closes #6145 from scwf/InConversion and squashes the following commits:

5c8ac6b [scwf] minir fix for InConversion

(cherry picked from commit edf09ea)
Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scwf @AmplabJenkins @SparkQA @liancheng @cloud-fan