[SPARK-6743][SQL] Fix empty projections of cached data #6165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #32759 has finished for PR 6165 at commit
|
Contributor
There was a problem hiding this comment.
If attributes.isEmpty, we'll always return Row.empty, so we don't need to create ColumnAccessors, right? The code looks weird to me, why we handle attributes.isEmpty this way?
Contributor
Author
There was a problem hiding this comment.
We need at least one column so that we know how many rows to produce, but we should not include it in the output otherwise we will not match the schema we are claiming to have. It would be better to just remember the number of rows in a partition and use that instead. This is just a quick fix so we don't return the wrong answer.
Conflicts: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
Contributor
Author
|
test this please |
|
Test build #33272 has finished for PR 6165 at commit
|
Contributor
Author
|
test this please |
|
Test build #33290 has finished for PR 6165 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 22, 2015
Author: Michael Armbrust <michael@databricks.com> Closes #6165 from marmbrus/wrongColumn and squashes the following commits: 4fad158 [Michael Armbrust] Merge remote-tracking branch 'origin/master' into wrongColumn aad7eab [Michael Armbrust] rxins comments f1e8df1 [Michael Armbrust] [SPARK-6743][SQL] Fix empty projections of cached data (cherry picked from commit 3b68cb0) Signed-off-by: Michael Armbrust <michael@databricks.com>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 28, 2015
Author: Michael Armbrust <michael@databricks.com> Closes apache#6165 from marmbrus/wrongColumn and squashes the following commits: 4fad158 [Michael Armbrust] Merge remote-tracking branch 'origin/master' into wrongColumn aad7eab [Michael Armbrust] rxins comments f1e8df1 [Michael Armbrust] [SPARK-6743][SQL] Fix empty projections of cached data
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
Author: Michael Armbrust <michael@databricks.com> Closes apache#6165 from marmbrus/wrongColumn and squashes the following commits: 4fad158 [Michael Armbrust] Merge remote-tracking branch 'origin/master' into wrongColumn aad7eab [Michael Armbrust] rxins comments f1e8df1 [Michael Armbrust] [SPARK-6743][SQL] Fix empty projections of cached data
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Author: Michael Armbrust <michael@databricks.com> Closes apache#6165 from marmbrus/wrongColumn and squashes the following commits: 4fad158 [Michael Armbrust] Merge remote-tracking branch 'origin/master' into wrongColumn aad7eab [Michael Armbrust] rxins comments f1e8df1 [Michael Armbrust] [SPARK-6743][SQL] Fix empty projections of cached data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.