Skip to content

[CORE] [TEST] Fix SimpleDateParamTest #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scwf wants to merge 2 commits into from
Closed

[CORE] [TEST] Fix SimpleDateParamTest #6377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb74f0
fix SimpleDateParamSuite
scwf May 25, 2015
b8df1e5
Update SimpleDateParamSuite.scala
scwf May 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...k/status/api/v1/SimpleDateParamTest.scala → .../status/api/v1/SimpleDateParamSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ package org.apache.spark.status.api.v1

import org.scalatest.{Matchers, FunSuite}

class SimpleDateParamTest extends FunSuite with Matchers {
class SimpleDateParamSuite extends FunSuite with Matchers {

test("date parsing") {
new SimpleDateParam("2015-02-20T23:21:17.190GMT").timestamp should be (1424474477190L)
new SimpleDateParam("2015-02-20T17:21:17.190CST").timestamp should be (1424474477190L)
new SimpleDateParam("2015-02-20").timestamp should be (1424390400000L) // GMT
new SimpleDateParam("2015-02-20T17:21:17.190EST").timestamp should be (1424470877190L)
Copy link
Member

@srowen srowen May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct test though I think @squito's intent was to test the same point in time, 2015-02-20T18:21:17.190EST, as it did before. Anyway, already LGTM

Copy link
Contributor

@squito squito May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it doesn't really matter. this looks good, thanks for the fix! I'm merging this now

new SimpleDateParam("2015-02-20").timestamp should be (1424390400000L) // GMT
}

}