[SPARK-7558] Demarcate tests in unit-tests.log (1.3)#6602
Closed
andrewor14 wants to merge 9 commits intoapache:branch-1.3from
Closed
[SPARK-7558] Demarcate tests in unit-tests.log (1.3)#6602andrewor14 wants to merge 9 commits intoapache:branch-1.3from
andrewor14 wants to merge 9 commits intoapache:branch-1.3from
Conversation
added 8 commits
June 2, 2015 18:52
This is such that test suites in all modules can extend SparkFunSuite. Conflicts: sql/catalyst/pom.xml
This is a big commit. In addition to just doing a search and replace there is actually more work to do in ensuring that the correct imports are introduced and the unused ones removed. This step is largely automated. :) Note that we exclude everything in the flume-sink module because the dependencies do not work out there. A larger comment will be added later to document why this is so.
Conflicts: core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
In core/test, it turns out that selenium is bringing in guava 15, but the rest of Spark we use guava 14, which is evicted. Since we made catalyst/test depend on core/test, and hive/test depends on catalyst/test, hive tests are getting guava 15, which results in java.lang.IllegalAccessError because of a dependency conflict. This is resolved by excluding guava 15 from selenium in core/test.
Conflicts: sql/hive-thriftserver/pom.xml
This is a follow-up patch to apache#6441. Author: Andrew Or <andrew@databricks.com> Closes apache#6510 from andrewor14/extends-funsuite-check and squashes the following commits: 6618b46 [Andrew Or] Exempt SparkSinkSuite from the FunSuite check 99d02ac [Andrew Or] Merge branch 'master' of github.com:apache/spark into extends-funsuite-check 48874dd [Andrew Or] Guard against direct uses of FunSuite / FunSuiteLike Conflicts: scalastyle-config.xml
This was referenced Jun 3, 2015
Contributor
Author
|
hive-thriftserver tests probably won't pass |
|
Test build #34048 has finished for PR 6602 at commit
|
|
Test build #34050 has finished for PR 6602 at commit
|
Contributor
Author
|
streaming flaky test. Jenkins retest this please |
|
Test build #34062 has finished for PR 6602 at commit
|
Contributor
Author
|
Weird objenesis failures again. retest this please. |
|
Test build #34072 has finished for PR 6602 at commit
|
Contributor
Author
|
YES this passed tests! I'm merging it into branch-1.3. |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2015
This includes the following commits: original: 9eb222c hotfix1: 8c99793 hotfix2: a4f2412 scalastyle check: 609c492 --- Original patch #6441 Branch-1.4 patch #6598 Author: Andrew Or <andrew@databricks.com> Closes #6602 from andrewor14/demarcate-tests-1.3 and squashes the following commits: a75ff8f [Andrew Or] Fix hive-thrift server log4j problem f782edd [Andrew Or] [SPARK-7558] Guard against direct uses of FunSuite / FunSuiteLike 2b7a4f4 [Andrew Or] Fix tests? fec05c2 [Andrew Or] Fix tests 5342d50 [Andrew Or] Various whitespace changes (minor) 9af2756 [Andrew Or] Make all test suites extend SparkFunSuite instead of FunSuite 192a47c [Andrew Or] Fix log message 95ff5eb [Andrew Or] Add core tests as dependencies in all modules 8dffa0e [Andrew Or] Introduce base abstract class for all test suites
asfgit
pushed a commit
that referenced
this pull request
Jun 4, 2015
This includes the following commits: original: 9eb222c hotfix1: 8c99793 hotfix2: a4f2412 scalastyle check: 609c492 --- Original patch #6441 Branch-1.3 patch #6602 Author: Andrew Or <andrew@databricks.com> Closes #6598 from andrewor14/demarcate-tests-1.4 and squashes the following commits: 4c3c566 [Andrew Or] Merge branch 'branch-1.4' of github.com:apache/spark into demarcate-tests-1.4 e217b78 [Andrew Or] [SPARK-7558] Guard against direct uses of FunSuite / FunSuiteLike 46d4361 [Andrew Or] Various whitespace changes (minor) 3d9bf04 [Andrew Or] Make all test suites extend SparkFunSuite instead of FunSuite eaa520e [Andrew Or] Fix tests? b4d93de [Andrew Or] Fix tests 634a777 [Andrew Or] Fix log message a932e8d [Andrew Or] Fix manual things that cannot be covered through automation 8bc355d [Andrew Or] Add core tests as dependencies in all modules 75d361f [Andrew Or] Introduce base abstract class for all test suites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the following commits:
original: 9eb222c
hotfix1: 8c99793
hotfix2: a4f2412
scalastyle check: 609c492
Original patch #6441
Branch-1.4 patch #6598